google / model-viewer

Easily display interactive 3D models on the web and in AR!
https://modelviewer.dev
Apache License 2.0
6.71k stars 799 forks source link

npm installation fails, because model-viewer depends on the old 157 version of Three JS #4599

Closed teneon closed 6 months ago

teneon commented 6 months ago

Description

Hi there, i am on ubuntu 22.04 ,i have Three JS version 159 installed.

When try to add model-viewer (currently latest version 3.3.0) npm i @google/model-viewer@3.3.0

i get the following error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: myproject@0.0.1
npm ERR! Found: three@0.159.0
npm ERR! node_modules/three
npm ERR!   three@"^0.159.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer three@"^0.157.0" from @google/model-viewer@3.3.0
npm ERR! node_modules/@google/model-viewer
npm ERR!   @google/model-viewer@"3.3.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

How can i fix this, i wouldn't want to downgrade Three JS to 157 version of course and i find it weird to require 157, because in package.json as dependency for model-viewer the 159 version is listed.

Any help appreciated! :-)

best regards, Jim