Closed jsantell closed 5 years ago
Especially as we think about renaming xr-model
to ar-model
, I think the
desire for ar is already explicit. Removing it makes sense to me.
On Fri, Oct 26, 2018 at 8:48 AM Jordan Santell notifications@github.com wrote:
Thoughts on removing ar attribute? Rational being this should just be for "free" on platforms that can support it, rather than something one explicitly has to ask for.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PolymerLabs/xr-model/issues/47, or mute the thread https://github.com/notifications/unsubscribe-auth/AAiWw8g-FPuRuvOJG6cN21MLC6fDz2YUks5uoy7KgaJpZM4X8gA1 .
Echoing discussion in https://github.com/PolymerLabs/xr-model/pull/61#discussion_r230193053
I think it's fine to pick any given default. However, I also think it's important to give the content author control over what is actually shown to the end user. They may not want a "present in AR" button in some contexts or at all. A boolean configuration is an easy way to enable this flexibility.
Related to this topic, the ar
attribute might be better as an ar-controls
attribute. Instead of thinking of it as enabling or disabling AR altogether, we should think of it as enabling or disabling the built-in controls for launching AR.
I think that "AR" (WebXR, ML, iOS, etc.) should be the default, and if for some reason, someone's visiting this content on Helio, Chrome Canary with WebXR flags, or on iOS with a USDZ provided, which is already a terribly small subset of users, it "just works" without having to opt in. This is part of the "works out of the box" story, rather than needing to explicitly enable, or worse, enable for different AR platforms (would have to keep up to date on what is supported, and update content accordingly). If a developer wanted to explicitly disable AR, we could provide a disable-ar
attribute, or disable-{webxr|magicleap}
for individual platforms.
We should make this work by default with AR, and have an attribute for the exceptional case. Thoughts?
Thoughts on removing
ar
attribute? Rational being this should just be for "free" on platforms that can support it, rather than something one explicitly has to ask for.