google / model-viewer

Easily display interactive 3D models on the web and in AR!
https://modelviewer.dev
Apache License 2.0
6.88k stars 816 forks source link

Frames Rendering to Incorrect Canvas - Multiple Model-Viewers on Page #4705

Closed cpiggott closed 6 months ago

cpiggott commented 6 months ago

Description

When looking through the Model-Viewer examples page, I ran into an issue when there was more than one Model-Viewer rendered on the page at any time. As I scroll from one example to the next, you'll see in the attached video that the model/scene expected for one instance renders to the other and then bounces back and forth.

Live Demo

See the attached video.

Version

Browser Affected

OS

elalish commented 6 months ago

Ugh, that's bad. I fixed a bunch of stuff like that years ago and haven't ever reproed since. My Macbook is on OS 14.4, but I didn't have the problem back when I was on 13 either. Do you have the same problem on other browsers or machines? Do any earlier versions of MV work properly (some kind of regression)?

cpiggott commented 6 months ago

I haven't had issues until recently, but I don't know when it started. I might have some time later this week to try with a few older versions if I can repro with a local instance.

I'm not seeing the same issue on other browsers, but I am seeing artifacting now on Safari which I haven't seen before.

Screenshot 2024-03-11 at 2 07 44 PM
elalish commented 6 months ago

This is starting to look like a GPU driver issue - is there anything you can update on your system? It should be easy to test older versions by changing the version string here: https://ajax.googleapis.com/ajax/libs/model-viewer/3.4.0/model-viewer.min.js

cpiggott commented 6 months ago

I'll see about updating to 14.4 tonight and report back.

cpiggott commented 6 months ago

Updates solved the issue. Sorry for the false alarm!

elalish commented 6 months ago

Whew! Thanks for letting us know.