search

google / model-viewer

Easily display interactive 3D models on the web and in AR!
https://modelviewer.dev
Apache License 2.0
6.84k stars 809 forks source link

Require 'src' attribute #64

Closed jsantell closed 5 years ago

jsantell commented 5 years ago

For inline, WebXR, and Magic Leap, we'll need a glTF/glb file. There's a scenario where only the USDZ is provided, with a poster, which is more or less no different from iOS's native AR Quick Look.

This may already work due to the mixin pattern, but something we should confirm, and/or clarify in docs.

cdata commented 5 years ago

Note that the use case of "poster only + quick look" is not any easier to achieve with our element than with Apple's syntax alone. Apple syntax:

<a href="model.usdz" rel="ar">
  <img src="model-poster.png">
</a>

Our syntax:

<xr-model ios-src="model.usdz" poster="model-poster.png">
</xr-model>

All that to say that I think we can triage this scenario as "low priority" compared to any other that involves using the src attribute.

cdata commented 5 years ago

This has been clarified in docs and is the current behavior of the element, so I'm going to close off this issue.