google / model_search

Apache License 2.0
3.26k stars 462 forks source link

sqlite default filename is not Windows compatible #63

Open DeanIsMe opened 2 years ago

DeanIsMe commented 2 years ago

File model_search/metadata/ml_metadata_db.py, lines 102-103 are:

        self._connection_config.sqlite.filename_uri = (
            "/tmp/filedb-%d" % random.randint(0, 1000000))

/tmp/... is of course not a valid path for Windows. Can you update this path such that it chooses a valid path when running on Windows?