Parse CIJob maps once - Githubissues

google / mono_repo.dart

Allows easy management of repositories with multiple Dart packages

https://pub.dev/packages/mono_repo

BSD 3-Clause "New" or "Revised" License

159 stars 32 forks source link

Parse CIJob maps once #489

Closed natebosch closed 2 months ago

natebosch commented 2 months ago

Move the parse operation out of the loop across OS and SDK combinations. Change from a factory to a static method that returns a record with the two fields that get parsed out of the yaml map at this level. The parse method creates a copy of the map, which shouldn't be necessary to do more than once.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10293209266

Details

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.56%

Totals
Change from base Build 10015285761:	0.0%
Covered Lines:	1298
Relevant Lines:	1535

💛 - Coveralls

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.56%. Comparing base (62562fe) to head (4193466).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #489 +/- ## ======================================= Coverage 84.56% 84.56% ======================================= Files 35 35 Lines 1535 1535 ======================================= Hits 1298 1298 Misses 237 237 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.