google / monologue

A monitor that checks that Certificate Transparency Logs are complying with RFC 6962 and the Chromium Certificate Transparency Log Policy.
Apache License 2.0
40 stars 15 forks source link

Store root certificates fetched by rootsgetter #23

Closed RJPercival closed 5 years ago

RJPercival commented 5 years ago

Just uses print.Storage at the moment, which simply prints out the number of root certificates (no storing of certificates actually occurs). A new storage implementation will actually store the certificates in the future.

taknira commented 5 years ago

This PR seems to be based on the refactor one that we decided against, so will probably need some re-working to get it in on top of the repo without that?

RJPercival commented 5 years ago

I've rebased this.

codecov-io commented 5 years ago

Codecov Report

Merging #23 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   60.38%   60.38%           
=======================================
  Files           4        4           
  Lines         154      154           
=======================================
  Hits           93       93           
  Misses         59       59           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f1731c...d70442b. Read the comment docs.