search

google / monologue

A monitor that checks that Certificate Transparency Logs are complying with RFC 6962 and the Chromium Certificate Transparency Log Policy.
Apache License 2.0
40 stars 15 forks source link

Use certificate-transparency-go/schedule package #33

Closed RJPercival closed 5 years ago

RJPercival commented 5 years ago

Handles running a func periodically while respecting contexts. Allows us to remove some duplicated code and make the code a bit more readable. There is a small behavioural change - the getters will run immediately, rather than waiting for period before doing anything.

codecov-io commented 5 years ago

Codecov Report

Merging #33 into master will increase coverage by 1.89%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   58.49%   60.38%   +1.89%     
==========================================
  Files           4        4              
  Lines         159      154       -5     
==========================================
  Hits           93       93              
+ Misses         64       59       -5     
  Partials        2        2
Impacted Files Coverage Δ
sthgetter/sthgetter.go 30.61% <0%> (+2.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b11a32...dbda6f7. Read the comment docs.