google / monologue

A monitor that checks that Certificate Transparency Logs are complying with RFC 6962 and the Chromium Certificate Transparency Log Policy.
Apache License 2.0
40 stars 15 forks source link

Make certsubmitter be able to issue certificates and pre-certificates #68

Closed Mercurrent closed 4 years ago

Mercurrent commented 4 years ago

Removed usage of precert submission out of this PR. Only implementation left.

codecov-io commented 4 years ago

Codecov Report

Merging #68 into master will decrease coverage by 2.45%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage    65.5%   63.04%   -2.46%     
==========================================
  Files          12       12              
  Lines         487      506      +19     
==========================================
  Hits          319      319              
- Misses        138      157      +19     
  Partials       30       30
Impacted Files Coverage Δ
certsubmitter/certsubmitter.go 18.33% <0%> (-8.5%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2842a9a...43a3a76. Read the comment docs.

Mercurrent commented 4 years ago

PTAL

Mercurrent commented 4 years ago

Refactored the commit structure, PTAL.

Mercurrent commented 4 years ago

Comments acknowledges. PTAL

Mercurrent commented 4 years ago

PTAL