google / moveit

Apache License 2.0
166 stars 18 forks source link

Create a New by consuming a UniquePtr. #29

Closed adetaylor closed 2 years ago

adetaylor commented 2 years ago

Work in progress. There's more duplication here than is ideal (it would be nice if the existing mov function could be made to apply to cxx::UniquePtrs). I'm not at all sure this is sound yet.

adetaylor commented 2 years ago

@mcy I've addressed all the comments I know how to address, and replied to the others! Thanks as ever for wading through my code.