search

google / mozc

Mozc - a Japanese Input Method Editor designed for multi-platform
Other
2.32k stars 330 forks source link

Zombie Process Prevention #830

Closed phoepsilonix closed 8 months ago

phoepsilonix commented 8 months ago

Description

If you start and close the mozc_tool, there are cases where the zombie process remains, so prevent it.

Modified code locations

src/base/process.cc

Confirmation of the acceptable code locations

Check https://github.com/google/mozc/blob/master/CONTRIBUTING.md and confirm whether all modified files are acceptable for pull requests. "Yes"

yukawa commented 8 months ago

Thank you for the pull request, but unfortunately src/base/process.cc isn't yet included in the list of files and directories that we are able to accept pull requests as of writing. https://github.com/google/mozc/blob/af209061632ba7dcc64b63bd06eb988974375508/CONTRIBUTING.md?plain=1#L23-L38

Can you start a discussion thread first at https://github.com/google/mozc/discussions ? To me, the right long term solution looks to be to stopping relying on posix_spawn.