search

google / mozc

Mozc - a Japanese Input Method Editor designed for multi-platform
Other
2.4k stars 348 forks source link

Simplify `mozc::win32::UninstallHelper` #866

Closed yukawa closed 6 months ago

yukawa commented 8 months ago

Description

This is a TODO task to simplify the custom action logic when uninstalling Mozc in Windows. https://github.com/google/mozc/blob/affc4ad6481fe444a866d4c7e9ec4788588931b9/src/win32/installer/installer_oss_64bit.wxs#L397-L408

Mozc has already stopped supporting IMM32 (c777afc8722e5ffaffc803416be92928a5fdab54), and we have already removed adead code that was used only for IMM32 from many places, there still remain several pieces of code that were intended to be used only under IMM32 environment around mozc::win32::UninstallHelper. https://github.com/google/mozc/blob/affc4ad6481fe444a866d4c7e9ec4788588931b9/src/win32/base/uninstall_helper.h#L68-L85

Version or commit-id

affc4ad6481fe444a866d4c7e9ec4788588931b9

Environment

yukawa commented 6 months ago

The main cleanup should be done with a118253a21e25e9291f9525239e6701e152b9dd0.