google / mtail

extract internal monitoring data from application logs for collection in a timeseries database
Apache License 2.0
3.82k stars 378 forks source link

chore: Remove excessive TAB in one import statement #827

Closed alexandear closed 5 months ago

alexandear commented 5 months ago

This PR fixes the formatting of import statements in one file.

Details

The PR arose when I ran gci linter and found that this tool broke on imports with TABS at the end:

❯ gci diff internal/mtail/mtail.go
Error: 26:42: expected ';', found "go.opencensus.io/zpages" (and 7 more errors)

But when I remove this TAB thegci working fine:

❯ gci diff internal/mtail/mtail.go
--- internal/mtail/mtail.go
+++ internal/mtail/mtail.go
@@ -21,8 +21,8 @@
        "github.com/google/mtail/internal/tailer"
        "github.com/prometheus/client_golang/prometheus"
        "github.com/prometheus/client_golang/prometheus/collectors"
-       "github.com/prometheus/client_golang/prometheus/promhttp"
        vc "github.com/prometheus/client_golang/prometheus/collectors/version"
+       "github.com/prometheus/client_golang/prometheus/promhttp"
        "github.com/prometheus/common/version"
        "go.opencensus.io/zpages"
 )
jaqx0r commented 5 months ago

Thanks for the fix!

github-actions[bot] commented 5 months ago

Unit Test Results

       1 files  ±0       27 suites  ±0   8m 47s :stopwatch: +5s    645 tests ±0     644 :heavy_check_mark: ±0  1 :zzz: ±0  0 :x: ±0  1 908 runs  ±0  1 905 :heavy_check_mark: ±0  3 :zzz: ±0  0 :x: ±0 

Results for commit d9dc57db. ± Comparison against base commit d62c1170.

github-actions[bot] commented 5 months ago

Unit Test Results

       1 files  ±0       27 suites  ±0   8m 43s :stopwatch: -1s    645 tests ±0     644 :heavy_check_mark: ±0  1 :zzz: ±0  0 :x: ±0  1 908 runs  ±0  1 905 :heavy_check_mark: ±0  3 :zzz: ±0  0 :x: ±0 

Results for commit 7b1512a9. ± Comparison against base commit d62c1170.