google / mtail

extract internal monitoring data from application logs for collection in a timeseries database
Apache License 2.0
3.84k stars 378 forks source link

What’s up with the tags? #847

Closed ruuda closed 6 months ago

ruuda commented 6 months ago

Thank you for building Mtail. I am working on build automation that automatically detects new releases, and yesterday it picked up a large number of new tags:

2024-04-25-mtail-tags

Just to double check, was this intentional, or might it be a bug in your release automation? Releasing 14 new release candidates in one day seems a bit excessive to me.

jaqx0r commented 6 months ago

I'm trying to test release signature verification, and it's a massive pain to debug. I don't like it either

On Thu, 25 Apr 2024, 10:13 Ruud van Asseldonk, @.***> wrote:

Thank you for building Mtail. I am working on build automation that automatically detects new releases, and yesterday it picked up a large number of new tags:

2024-04-25-mtail-tags.png (view on web) https://github.com/google/mtail/assets/506953/51346e2f-0a8d-4eed-9be3-a8d02c9b486d

Just to double check, was this intentional, or might it be a bug in your release automation? Releasing 14 new release candidates in one day seems a bit excessive to me.

— Reply to this email directly, view it on GitHub https://github.com/google/mtail/issues/847, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXFX66JOSG7Z7X4DZ2PUYTY7C3KTAVCNFSM6AAAAABGYLXCVSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DEOJWHAYTGNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

jaqx0r commented 6 months ago

What's your release automation? It sounds interesting.

On Thu, 25 Apr 2024, 10:26 Jamie Wilkinson, @.***> wrote:

I'm trying to test release signature verification, and it's a massive pain to debug. I don't like it either

On Thu, 25 Apr 2024, 10:13 Ruud van Asseldonk, @.***> wrote:

Thank you for building Mtail. I am working on build automation that automatically detects new releases, and yesterday it picked up a large number of new tags:

2024-04-25-mtail-tags.png (view on web) https://github.com/google/mtail/assets/506953/51346e2f-0a8d-4eed-9be3-a8d02c9b486d

Just to double check, was this intentional, or might it be a bug in your release automation? Releasing 14 new release candidates in one day seems a bit excessive to me.

— Reply to this email directly, view it on GitHub https://github.com/google/mtail/issues/847, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXFX66JOSG7Z7X4DZ2PUYTY7C3KTAVCNFSM6AAAAABGYLXCVSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DEOJWHAYTGNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ruuda commented 6 months ago

I'm trying to test release signature verification

I see, thank you for the clarification and the quick response. Maybe it is possible to test with a testing fork of this repository to not pollute this one? I can imagine it’s difficult to get approval for it and get everything set up though.

What's your release automation? It sounds interesting.

We have an internal build/package registry that builds a few dozen packages from source, mtail is one of them. (Most packages in there are ones where we really want to run the latest version. For mtail that is not a concern, we just added it because it’s not packaged for Ubuntu and this is the easiest way for us to get it running on our infrastructure.) It tracks in a database what tags we have binaries for, and then periodically it runs git ls-remote --tags to see if there are any new tags upstream. If there are and they match a selector, it builds them and sends a notification. Usually we have a selector that ignores release candidates, but for mtail the only releases in the past few years have been -rc versions, so here we do build them.

jaqx0r commented 6 months ago

I'll add the word 'test' at the end of the tag name.

Once this is working I plan on stopping the RC versions.

Hopefully that helps your automation.

On Thu, 25 Apr 2024, 10:42 Ruud van Asseldonk, @.***> wrote:

I'm trying to test release signature verification

I see, thank you for the clarification and the quick response. Maybe it is possible to test with a testing fork of this repository to not pollute this one? I can imagine it’s difficult to get approval for it and get everything set up though.

What's your release automation? It sounds interesting.

We have an internal build/package registry that builds a few dozen packages from source, mtail is one of them. (Most packages in there are ones where we really want to run the latest version. For mtail that is not a concern, we just added it because it’s not packaged for Ubuntu and this is the easiest way for us to get it running on our infrastructure.) It tracks in a database what tags we have binaries for, and then periodically it runs git ls-remote --tags to see if there are any new tags upstream. If there are and they match a selector, it builds them and sends a notification. Usually we have a selector that ignores release candidates, but for mtail the only releases in the past few years have been -rc versions, so here we do build them.

— Reply to this email directly, view it on GitHub https://github.com/google/mtail/issues/847#issuecomment-2076672213, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXFX65V2XTX2YZRK6ANGJ3Y7C6WBAVCNFSM6AAAAABGYLXCVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZWGY3TEMRRGM . You are receiving this because you commented.Message ID: @.***>

ruuda commented 6 months ago

Yes that would be very useful, then we can ignore tags that contain test. Thanks! :heart:

jaqx0r commented 6 months ago

If you ignore mtails rc tags as well you'll get the builds again soon!

On Thu, 25 Apr 2024, 11:01 Ruud van Asseldonk, @.***> wrote:

Yes that would be very useful, then we can ignore tags that contain test. Thanks! ❤️

— Reply to this email directly, view it on GitHub https://github.com/google/mtail/issues/847#issuecomment-2076706821, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXFX66RB55UWTJPUHVKQY3Y7DA65AVCNFSM6AAAAABGYLXCVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZWG4YDMOBSGE . You are receiving this because you commented.Message ID: @.***>

jaqx0r commented 6 months ago

My testing is now complete. There won't be any more tag explosion (for a while...)