google / mug

A small Java 8 library (string manipulation, stream utils)
Apache License 2.0
367 stars 65 forks source link

Added Java 8 support #13

Closed bihu1 closed 5 years ago

bihu1 commented 5 years ago

I'll really want to use this lib in my Java 8 projects, so I wrote own support. Maybe it will be useful also for you.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

bihu1 commented 5 years ago

@googlebot I signed it

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

bihu1 commented 5 years ago

In BiStream class line 205 https://github.com/bihu1/mug/blob/706d6ba60b76f44908112420aa841b417d4aaaab/core/src/main/java/com/google/mu/util/stream/BiStream.java#L205 I added link to stackoverflow link, because in this place I use function, which I found there. I'm not sure license things, so I decided to tag this in this way.

fluentfuture commented 5 years ago

Thanks for the PR.

Unfortunately I've lost my 2-factor auth for a while and haven't been able to log into github.

I'll need to consult github support for what I can do.

In the meantime, you could use 2.x releases which were Java 8 compatible.

On Tue, Aug 6, 2019 at 3:08 AM bihu1 notifications@github.com wrote:

In BiStream class line 205, I added link to stackoverflow link, because in this place I use function, which I found there. I'm not sure license things, so I decided to tag this in this way.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/mug/pull/13?email_source=notifications&email_token=AA2MGEBNOC6N24EO5DVUBFLQDFEQXA5CNFSM4IJUOY42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3UUQXI#issuecomment-518604893, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2MGEH7MKUKYU5AX6PIYU3QDFEQXANCNFSM4IJUOY4Q .