google / myanmar-tools

Detect and convert the Zawgyi-One font encoding in C++, Java, JavaScript, PHP, and Ruby
Other
243 stars 87 forks source link

Add action for Ruby tests #84

Closed echeran closed 3 years ago

echeran commented 3 years ago

Side note: I'm not sure why, but when using the Ruby action, changing directories in subsequent steps was not stateful in the way that that I remember seeing in other actions. Regardless, the combining the command-line steps into a single command works.

sffc commented 3 years ago

Could you add back the minimum supported Ruby version test that was in Travis?

echeran commented 3 years ago

Sure thing, it should be there now.

The new changes triggered a new workflow execution in my personal fork, but for some reason, it isn't executing here.

sffc commented 3 years ago

LGTM but please resolve the conflict; maybe that is what is preventing the CI from running?