google / myanmar-tools

Detect and convert the Zawgyi-One font encoding in C++, Java, JavaScript, PHP, and Ruby
Other
243 stars 87 forks source link

MT-71 Removes the Travis CI configuration file. All CI targets are mi… #88

Closed gnrunge closed 3 years ago

gnrunge commented 3 years ago

…grated.

gnrunge commented 3 years ago

Target ruby-latest-jruby worked at the last commit a few days ago. Failure of the ruby-latest-jruby target is reproducible in a separate branch. No failure when using plain 'ruby-version: jruby' only, which I'd assume is the default version but most likely not the latest version. Any idea what is going on. It says 'bundle: command not found' (from 'install bundle').

gnrunge commented 3 years ago

Looks like one has to explicitly install the bundler: 'gem install bundler'.

sffc commented 3 years ago

Hmm. I don't know what's going on with jruby. The CI says specifically that bundler is installed:

Installing Bundler
  Using Bundler 2 shipped with jruby-head
  Took   0.00 seconds
gnrunge commented 3 years ago

LGTM.

Good find on the need to run gem install bundler. I guess that makes sense. (I suppose it all depends on which languages and/or build tools come pre-installed on the VM and/or by the extra relevant Github Actions we invoke.)

I added 'gem install bundler' just now and squashed it in to the pull request. All the MT CI targets now passing, waiting for fuzzer CI to finish.