search

google / nel-collector

Network Error Logging (NEL) collector
https://wicg.github.io/network-error-logging/
Apache License 2.0
39 stars 17 forks source link

Remove support for Go 1.8 #35

Closed dcreager closed 6 years ago

dcreager commented 6 years ago

That version is no longer supported by the Go team, so we don't need to run our test suite against it.

dcreager commented 6 years ago

In particular, the error message that we're getting in our Go 1.8 builds:

# golang.org/x/tools/go/internal/gcimporter
../../../golang.org/x/tools/go/internal/gcimporter/bexport.go:212: obj.IsAlias undefined (type *types.TypeName has no field or method IsAlias)

stems from an intentionally backwards-incompatible change in the gcimporter library. Others are seeing this, too (golang/go#28291, golang/tools#52), and the recommendation is to drop support for <1.10.