google / nerfactor

Neural Factorization of Shape and Reflectance Under an Unknown Illumination
https://xiuming.info/projects/nerfactor/
Apache License 2.0
440 stars 56 forks source link

Maybe this is a potential bug. #7

Closed bruinxiong closed 3 years ago

bruinxiong commented 3 years ago

In line 50-52 of nerfactor/nerfactor/util/vis.py, ############################# img = xm.io.img.load(path) img = img[:, :, :3] # discards alpha hw = img.shape[:2] ############################# The pred_lvis.png has no third channel similar to grey image. So, it should be changed to this as follows: ############################# Img = xm.io.img.load(path if len(img.shape) == 2: stacked_img = np.stack((img,)*3, axis=-1) img = stacked_img img = img[:, :, :3] # discards alpha hw = img.shape[:2] #############################

xiumingzhang commented 3 years ago

Thank you for the suggestion. Although I don't recall encountering this problem, it won't hurt to adopt this change you proposed. Incorporated this in f50a06c.

On Tue, Aug 24, 2021 at 6:44 AM Xiong Lin @.***> wrote:

In line 50-52 of nerfactor/nerfactor/util/vis.py, img = xm.io.img.load(path) img = img[:, :, :3] # discards alpha hw = img.shape[:2] The pred_lvis.png has no third channel similar to grey image. So, it should be changed to this as follows: Img = xm.io.img.load(path if len(img.shape) == 2: stacked_img = np.stack((img,)*3, axis=-1) img = stacked_img img = img[:, :, :3] # discards alpha hw = img.shape[:2]

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/nerfactor/issues/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXICPSK5EQHSJ4JD4CWAETT6NZXDANCNFSM5CWRUOHQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .