search

google / netstack

IPv4 and IPv6 userland network stack
Apache License 2.0
3.08k stars 278 forks source link

`go get` is broken since cdd605f5e2f5158c8d3f8f752cba0a53b0aac4ec #18

Closed tamird closed 5 years ago

tamird commented 5 years ago 
$ go get -u github.com/google/netstack/...
# github.com/google/netstack/tcpip/transport/ping
../go/src/github.com/google/netstack/tcpip/transport/ping/ping_packet_list.go:16:48: undefined: pingPacket
../go/src/github.com/google/netstack/tcpip/transport/ping/ping_packet_list.go:30:8: undefined: pingPacket
../go/src/github.com/google/netstack/tcpip/transport/ping/ping_packet_list.go:31:8: undefined: pingPacket
# github.com/google/netstack/tcpip/transport/icmp
../go/src/github.com/google/netstack/tcpip/transport/icmp/endpoint.go:31:2: undefined: icmpPacketEntry

This was broken in https://github.com/google/netstack/commit/cdd605f5e2f5158c8d3f8f752cba0a53b0aac4ec (https://github.com/google/gvisor/commit/b75aa515044367094e762985a4b1a1f0580e3ad6) which changed the names of generated files and the type definitions they contain.

@kevinGC @iangudger @amscanne

tamird commented 5 years ago

Fixed since https://github.com/google/netstack/commit/636916365c65986a3c56c8b1bc36314cfee82f40.