Closed allison-truhlar closed 2 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Closing this pull request to redo the commits with the correct email address associated for the CLA.
FYI you can always just force push to the same branch without creating a new pull request
Addresses issue #627.
playwright
as a dependency; removeswebdriverio
.playwright
as the browser provider rather thanwebdriverio
.npx playwright install
to thetest
andtest:watch
commands inpackage.json
. This is to ensureplaywright
updates after the initial install, to avoid getting the errorError: browserType.launch
, followed the by the instructions: "Looks like Playwright Test or Playwright was just installed or updated. Please run the following command to download new browsers:npx playwright install
.All tests pass in macOS 14.5 using this configuration.
I haven't completed the Google CLA yet - I am opening this as a draft as I wait for instructions on how to complete it at Janelia.