Fix browser test errs on mac

google / neuroglancer

WebGL-based viewer for volumetric data

Apache License 2.0

1.09k stars 299 forks source link

Fix browser test errs on mac #630

Open allison-truhlar opened 3 months ago

allison-truhlar commented 3 months ago

Addresses issue https://github.com/google/neuroglancer/issues/627.

Adds playwright as a dependency; removes webdriverio.
Configures Vitest to use playwright as the browser provider rather than webdriverio.
Adds npx playwright install to the test and test:watch commands in package.json. This is to ensure playwright updates after the initial install, to avoid getting the error Error: browserType.launch, followed the by the instructions: "Looks like Playwright Test or Playwright was just installed or updated. Please run the following command to download new browsers: npx playwright install.

All tests pass in macOS 14.5 using this configuration.

Replaces PR #628. These commits use the correct email address associated with the Janelia CLA.

jbms commented 3 months ago

Thanks!

Does this allow the WebGL tests to pass in Github actions on macOS? (See https://github.com/google/neuroglancer/commit/33f5eb5e4ceef81d221436764bbdc438724abbcd#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721)

allison-truhlar commented 3 months ago

I'm not sure - I just removed the if statement in the GitHub action to allow the tests including WebGL to run.

jbms commented 3 months ago

It looks like this still does not allow the tests to pass on macOS on github actions, but hopefully it will work in the future after https://github.com/microsoft/playwright/issues/30585 is fixed.

Per the description here (https://playwright.dev/docs/library#key-differences) does it work to just add @playwright/browser-chromium as a dev dependency rather than having to do npx playwright install?

allison-truhlar commented 3 months ago

In the latest commit, I tested adding @playwright/browser-chromim as a dev dependency and removing npx playwright install from the test commands - I can confirm this works.

mkitti commented 3 months ago

Error: browserType.launch: Executable doesn't exist at /Users/runner/Library/Caches/ms-playwright/chromium-1124/chrome-mac/Chromium.app/Contents/MacOS/Chromium

Would adding npx playwright install-deps chromium help resolve the client tests here?

allison-truhlar commented 3 months ago

@mkitti Which version of the PR did you get this error from? Is this after I added @playwright/browser-chromium as a dev dependency?

mkitti commented 3 months ago

Yes. You can see it in the Github Actions tests for client (macos-latest): https://github.com/google/neuroglancer/actions/runs/10289555738/job/28497954784?pr=630#step:14:18

allison-truhlar commented 2 months ago

Added npx playwright install-deps chromium to the workflow, per @mkitti's suggestion, to see if this resolves the test failure in GitHub actions.