google / ngx_brotli

NGINX module for Brotli compression
BSD 2-Clause "Simplified" License
2.08k stars 214 forks source link

Use as default for brotli_types the values from gzip_types #101

Open dilyanpalauzov opened 4 years ago

dilyanpalauzov commented 4 years ago

Considering that each self-respecting webserver offers both brotli and gzip at the same time, change the defaults of brotli_static to the value set in gzip_static and the the default value of brotli_types to the value set in gzip_types.

Possibly convince the developers of the gzip and gzip_static modules to export that values.

eustas commented 4 years ago

gzip & gzip_static modules are the part of nginx itself (https://github.com/nginx/nginx/tree/master/src/http/modules)

Unfortunately, even adding brotli_static wasn't warmly welcomed (though, it would be the best to have a single "*_static" module that understands both brotli and gzip).

dilyanpalauzov commented 4 years ago

See also https://trac.nginx.org/nginx/ticket/1961.

Jas0n99 commented 4 years ago

Unfortunately, even adding brotli_static wasn't warmly welcomed (though, it would be the best to have a single "*_static" module that understands both brotli and gzip).

Why is that? It's just one directive...