google / ngx_brotli

NGINX module for Brotli compression
BSD 2-Clause "Simplified" License
2.09k stars 214 forks source link

make[1]: Nothing to be done for 'modules' #149

Closed germebl closed 1 year ago

germebl commented 1 year ago

Issue:

Cant compile the brotli nginx modules. Its getting the error from the title when trying to "make modules".

Expected Behavior:

No errors and successfull compiling while trying to

Reproduce:

Installing depedencies

apt install build-essential libpcre3-dev libssl-dev zlib1g zlib1g-dev

changing directory

cd /opt

download nginx in the same version as i'm actually using from nginx stable repository

wget http://nginx.org/download/nginx-1.24.0.tar.gz

unpack

tar -xzf nginx-1.24.0.tar.gz

removing .tar.gz file

rm -rf nginx-1.24.0.tar.gz

download ngx brotli source code

git clone https://github.com/google/ngx_brotli

changing dir

cd /opt/ngx_brotli

installing submodules

git submodule update --init

getting compiling arguments from nginx

nginx -V

changing to the source code of nginx

cd /opt/nginx-1.24.0

configure

./configure 

with the default compiling options from installed 1.24.0 version

--prefix=/etc/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --http-client-body-temp-path=/var/cache/nginx/client_temp --http-proxy-temp-path=/var/cache/nginx/proxy_temp --http-fastcgi-temp-path=/var/cache/nginx/fastcgi_temp --http-uwsgi-temp-path=/var/cache/nginx/uwsgi_temp --http-scgi-temp-path=/var/cache/nginx/scgi_temp --user=nginx --group=nginx --with-compat --with-file-aio --with-threads --with-http_addition_module --with-http_auth_request_module --with-http_dav_module --with-http_flv_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_mp4_module --with-http_random_index_module --with-http_realip_module --with-http_secure_link_module --with-http_slice_module --with-http_ssl_module --with-http_stub_status_module --with-http_sub_module --with-http_v2_module --with-mail --with-mail_ssl_module --with-stream --with-stream_realip_module --with-stream_ssl_module --with-stream_ssl_preread_module --with-cc-opt='-g -O2 -ffile-prefix-map=/data/builder/debuild/nginx-1.24.0/debian/debuild-base/nginx-1.24.0=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC' --with-ld-opt='-Wl,-z,relro -Wl,-z,now -Wl,--as-needed -pie'

and with the brotli module

--with-compat --add-module=/opt/ngx_brotli

trying to make the modules

make modules

following error appears:

make -f objs/Makefile modules
make[1]: Entering directory '/opt/nginx-1.24.0'
make[1]: Nothing to be done for 'modules'.
make[1]: Leaving directory '/opt/nginx-1.24.0'
wyattoday commented 1 year ago

Same problem as here: https://github.com/google/ngx_brotli/issues/148#issuecomment-1703859910