search

google / ngx_brotli

NGINX module for Brotli compression
BSD 2-Clause "Simplified" License
2.1k stars 216 forks source link

Fix broken brotli build (upstream brotli dropped makefile support and sources.lst file) #150

Closed wyattoday closed 1 year ago

wyattoday commented 1 year ago

This PR fix the latest commit by fixing the config file to include the correct static libraries, drop support for the sources.lst file (which no longer exists), and updates the build instructions to get people up and running quickly.

Fixes https://github.com/google/ngx_brotli/issues/148 Fixes https://github.com/google/ngx_brotli/issues/149 Fixes https://github.com/google/ngx_brotli/issues/151

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

hao159 commented 1 year ago

hi @wyattoday have any update?

wyattoday commented 1 year ago

@hao159

It's up to @google-admin and @eustas to merge the PR. I just submitted it because we need it and figured everyone could benefit from the work we put in.

See https://github.com/google/ngx_brotli/issues/148#issuecomment-1706648408 for the solution in the meantime.

Google has mostly abandoned this project for some odd reason (like they abandon every piece of technology that doesn't generate them hundreds of billions of advertising dollars every year).

eustas commented 1 year ago

Thanks for the PR. Will land soon.

hao159 commented 1 year ago

@hao159

It's up to @google-admin and @eustas to merge the PR. I just submitted it because we need it and figured everyone could benefit from the work we put in.

See #148 (comment) for the solution in the meantime.

Google has mostly abandoned this project for some odd reason (like they abandon every piece of technology that doesn't generate them hundred of billions of advertising dollars every year).

thanks for your update.

eustas commented 1 year ago

I'm terribly sorry, but landing is blocked by CLA check. @wyattoday could you sign it, please.

wyattoday commented 1 year ago

I'm terribly sorry, but landing is blocked by CLA check. @wyattoday could you sign it, please.

Yep. Done.

eustas commented 1 year ago

Awesome. Landing.