google / ngx_brotli

NGINX module for Brotli compression
BSD 2-Clause "Simplified" License
2.09k stars 215 forks source link

Docs / readme improvement: clarify behavior with reverse proxied backends #163

Open binaryfire opened 8 months ago

binaryfire commented 8 months ago

Hi guys

Would it be possible to add some information to the readme re: how this module deals with reverse proxied content? Specifically:

I've spent quite a while searching for answers to this but there's very little info out there. Could someone help? I think covering it in the readme would help a lot of people.

Eagle3386 commented 2 weeks ago

@eustas? @PiotrSikora? Anyone?

PiotrSikora commented 2 weeks ago

1) Brotli filter doesn't recompress responses, see: https://github.com/google/ngx_brotli/blob/a71f9312c2deb28875acc7bacfdd5695a111aa53/filter/ngx_http_brotli_filter_module.c#L281-L285 2) gzip_proxied applies to proxied requests (clients), not proxied responses (backends).