google / node-gles

Apache License 2.0
323 stars 31 forks source link

Add travis and appveyor for prebuilding binaries #72

Open Prior99 opened 4 years ago

Prior99 commented 4 years ago

This adds prebuilt binaries for the last 4 node versions on 64-bit Windows, Linux and Mac. The binaries are built on travis and appveyor, the maintainers of this repository would need to enable both for this repository and generate an oauth token, adding them to into the corresponding configurations.

I also preliminarily published this on https://www.npmjs.com/package/node-gles-prebuilt until this is merged.


This change is Reviewable

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Prior99 commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

nkreeger commented 4 years ago

This is really great - thank you! Apologies for the lag on the review.

I know that building stuff on Node-gyp isn't always great and I was hoping to get to pre-built binaries at some point. Do you mind adding some documentation on how to pre-build binaries and upload them? I'd love for this to be community supported. As for storage, I'll have to look into what I can do on my end. If it's something easy as stashing on github I think we can do that pretty easy.