google / node-sec-roadmap

Some thoughts on how Node.js might respond to a changing security environment
https://nodesecroadmap.fyi/
Other
172 stars 29 forks source link

chore: only build Book once with `make serve` #19

Closed MylesBorins closed 6 years ago

MylesBorins commented 6 years ago

Currently make serve can end up building the book as many as three times before serving (depending on if dependencies are installed).

This commit removes the postinstall hook call to make book and also changes make serve to no longer depend on make book. Instead make serve will now rely on $(GITBOOK_DEPS) to ensure dependencies are installed and rely on gitbook serve to do the build.

AFAICT all functionality is maintained and the compilation time for first run is significantly improved.