search

google / nogotofail

An on-path blackbox network traffic security testing tool
Apache License 2.0
2.94k stars 417 forks source link

Make connections nonblocking #37

Closed chadbrubaker closed 9 years ago

chadbrubaker commented 9 years ago

This makes initial TCP connections to the server and the SSL MiTM establishment non blocking. This should help performance and scaling.

chadbrubaker commented 9 years ago

Timeouts are handled by the stale connection logic in server.py, there's no need for an explicit timeout in these operations.

chadbrubaker commented 9 years ago

Cleaned up some functions names to be more clear and made updating the select fds a little less brittle. Can you take another look?

klyubin commented 9 years ago

LGTM