search

google / nogotofail

An on-path blackbox network traffic security testing tool
Apache License 2.0
2.94k stars 418 forks source link

Improve ngtf File handling #81

Closed chadbrubaker closed 9 years ago

chadbrubaker commented 9 years ago

This (finally) adds support for a configurable directory for all the extra files used by ngtf and its handlers, set by -x/--extrasdir.

Additionally improve the handling of some of the pyopenssl files since it handles non-existent dhparams poorly.

klyubin commented 9 years ago

Why is an extras dir needed at all? Why not specify paths to all the needed files on per-file/per-feature basis? We already support that for some files, but not others (e.g., MiTM certs/keys).

chadbrubaker commented 9 years ago

I don't want handlers adding command line options right now so that kills per-file. Generally I think relying on ./ was always hacky and sad I just never got around to it.

Afaik the only input file that can be specified right now is the SSL cert for the blame server. Nothing related to handlers or the actual mitm is.

On Mon, Aug 10, 2015, 12:42 klyubin notifications@github.com wrote:

Why is an extras dir needed at all? Why not specify paths to all the needed files on per-file/per-feature basis? We already support that for some files, but not others (e.g., MiTM certs/keys).

— Reply to this email directly or view it on GitHub https://github.com/google/nogotofail/pull/81#issuecomment-129580189.