Closed mkenne11 closed 9 years ago
Alex can you take a look?
Are the renames needed? We need to make sure that they don't cause issues with the bazel build.
No worries. TBH I only tried building the client from inside the Android Studio IDE.
I experimented with the project files and found the latest committed project files build for me from the command line using gradlew (./gradlew).
Unfortunately I had to include the /gradle/wrapper directory. I also added the local.properties to point to the location of the Android SDK - however I looks like you can exclude this file if you ANDROID_HOME environment variable: http://stackoverflow.com/questions/19794200/gradle-android-and-the-android-home-sdk-location
I don't fully understand gradle and building from the command line yet. I'll explore further to see if I can minimize the project files further.
BTW. Hopefully I set the paths correctly in the Bazel BUILD file to where they reside in the Android Studio structure.
Just a couple of minor issues:
I made the updates requested to the Android client BUILD and .gitignore files.
Also, I found I could exclude gradle wrapper artifacts (gradlew & gradlew.bat, and /gradle/wrapper folder). See latest commit.
The comment below is the procedure I followed on my local (Ubuntu) machine to do a gradle build from the command line. Hopefully it works for you too :)
Create the Gradle Wrapper using the command:
gradle wrapper
The .gradle & gradle directories, and gradlew & gradlew.bat files should be created.
Build the project. To test I created a debug (unsigned) build using the command:
./gradlew assembleDebug
The app/build directory should be created containing the compiled apk and other build files.
This looks good. Would you please squash all these commits into one and re-upload (e.g., git push --force) or create separate pull request? The current individual commits will look weird in the commit log: they make breaking changes. Thanks in advance.
No worries. I used the current PR - I squashed the 3 commits into one and did a forced update. Let me know if any additional changes are needed.
I'll also submit a PR soon after I have migrated the Android test client to Android Studio.
Thank you very much!
The Eclipse Android client project was migrated to an Android Studio project.
When the project is opened in Android Studio the "Gradle Sync" dialog will appear stating: Gradle settings for this project are not configured yet.
Selecting the "OK" option will build the Gradle wrapper.