search

google / nogotofail

An on-path blackbox network traffic security testing tool
Apache License 2.0
2.94k stars 418 forks source link

imagereplace attack doesn't replace some images #92

Open klyubin opened 8 years ago

klyubin commented 8 years ago

The imagereplace attack doesn't always replace images. I wonder if it's because it can't handle some image types (e.g., webp).

chadbrubaker commented 8 years ago

It should support anything with a content type that starts with image, see https://github.com/google/nogotofail/blob/dev/nogotofail/mitm/connection/handlers/data/http.py#L416

It could be more issues with the http detection?