search

google / nogotofail

An on-path blackbox network traffic security testing tool
Apache License 2.0
2.94k stars 418 forks source link

Add a TLS Record base handler #94

Closed chadbrubaker closed 8 years ago

chadbrubaker commented 8 years ago

We currently have too many handlers implementing their own record parsing and buffering. This PR adds a base class they can use to skip that and focus only on the records.

Additionally, to make this feasible TLS parsing was improved to properly support fragmented records and more cleanly support incomplete reads of records.

mkenne11 commented 8 years ago

Just wondering when you are looking to commit this PR into the dev branch? Am keen to finish my noforwardsecrecy and sunsetsha1 handler PRs :)

chadbrubaker commented 8 years ago

Woops sorry, I though I got this merged D: