search

google / novm

Experimental KVM-based VMM for containers, written in Go.
Apache License 2.0
1.68k stars 123 forks source link

Change python shebang to use python2 #16

Closed hamo closed 9 years ago

hamo commented 9 years ago

Some distributions use python3 as default python, so move shebang to env python2.

Signed-off-by: Yang Bai hamo.by@gmail.com

Review on Reviewable

amscanne commented 9 years ago

Hi @hamo, thanks for pointing this out.

I'd prefer to address the underlying issues rather than building in a hard dependency to python 2. Can you check if pull req #22 addresses the python3 issues? Thanks!

hamo commented 9 years ago

@amscanne both hard code python2 and making scripts compatible with python3 are fine way to fix this issue and I also believe that compatibility is better. Feel free to close this merge request.

amscanne commented 9 years ago

This should be fixed by: 52be905d0d40b0a802856637d1ae420733961385.