search

google / novm

Experimental KVM-based VMM for containers, written in Go.
Apache License 2.0
1.68k stars 123 forks source link

[RFC] Move instance meta file under dir and output novmm log #25

Closed hamo closed 9 months ago

hamo commented 9 years ago

This patchset first moves all one instance related file from .novm/instances/ to .novm/instances/$PID/, including meta file, the writable dir (rename from $PID to writable) and a new log file output from novmm named novmm.log.

Then it enables novmm to output its log to the file .novm/instances/$PID/novmm.log, this will really help debugging.

Now novm list function is broken since I changed the dir structure. Will push next commit to fix it.

Review on Reviewable

amscanne commented 9 years ago

I'm generally good with this.

Unless I'm mistaken, I think there's a small problem with the self._myInstance member. I'm fine with either fixing it via my suggestion or if you have some other approach.

hamo commented 9 years ago

@amscanne novm list is fixed with last commit, I have tested with novm list and novm kernels which covers both old data structure and new one.

hamo commented 9 years ago

@amscanne I have rebased all commits and squash them into one commit. Please kindly review.

hamo commented 9 years ago

I think I finally get your idea. This commit removes self._myInstance and rebased to your last master commit.