googlebot
commented
5 years ago Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
jlebar
BowNV
chsigg
During testing, the following issue was reported " [235 / 251] Compiling external/com_google_protobuf/src/google/protobuf/descriptor.pb.cc [for host]; 2s linux-sandbox ... (7 actions running) [289 / 298] Compiling cudnn_conv_test.cc; 0s linux-sandbox ... (7 actions running) ERROR: .../cuda/_tests/google_cudnn_test/codes/nvidia_libs_test-master/BUILD:110:1: C++ compilation of rule '//:cudnn_test' failed (Exit 1) gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 103 argument(s) skipped) Use --sandbox_debug to see verbose messages from the sandbox cudnn_conv_test.cc:1203:25: error: expected constructor, destructor, or type conversion before '(' token INSTANTIATE_TEST_SUITE_P( ^ cudnn_conv_test.cc:1208:25: error: expected constructor, destructor, or type conversion before '(' token INSTANTIATE_TEST_SUITE_P(Conv2dFilter3x3, ConvolutionTest, ^ cudnn_conv_test.cc:1242:1: error: expected '}' at end of input } // namespace nvidia_libs_test ^ cudnn_conv_test.cc:1242:1: error: expected '}' at end of input cudnn_conv_test.cc: In function 'double nvidia_libs_test::{anonymous}::GetToleranceScale(const nvidia_libs_test::proto::ConvolutionConfig&)': cudnn_conv_test.cc:148:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ "
Since INSTANTIATE_TEST_SUITE_P can be supported by master branch, I created this request for approval. And Sha256 was generated based on today's googletest master and local testing was done and passed!
Thanks Bo