search

google / oauth2l

oauth2l ("oauth tool") is a simple CLI for interacting with Google API authentication.
Apache License 2.0
652 stars 81 forks source link

Inherit OS stdio in curl command #147

Closed timdp closed 1 year ago

timdp commented 1 year ago

Fixes #146.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

timdp commented 1 year ago

Apologies for the force-pushes. I thought I needed to change the email address on the commit to have the CLA check pick up on it.

timdp commented 1 year ago

Oh, sorry. When go test didn't do anything, I assumed there were no tests, but I should have checked the Makefile or integration folder.

I've added -s to the curl command in the tests to re-match stdout with the snapshots. Test are passing again now.

Alternatively, I suppose we could inspect curl's default output, but that would also involve normalizing the URL and progress bar before snapshotting.

DavidDTA commented 2 weeks ago

This was merged almost 2 years ago, but there has been no release since then to make it available. Is there any chance a new release could be created?

andyrzhao commented 1 week ago

Yes, I can try to push out updated releases for all platforms. ETA end of this year at the latest.