Raise error on changing shape in assign

google / objax

Apache License 2.0

769 stars 77 forks source link

Raise error on changing shape in assign #123

Closed carlini closed 3 years ago

carlini commented 3 years ago

This PR is a cleaned up version of #115.

The checking logic is somewhat complicated in case someone decides to JIT a Parallel() module, it will still do the right thing and won't accidentally cause errors.

carlini commented 3 years ago

Build fails as a result of #124.

carlini commented 3 years ago

How did this test ever pass. Either that or I'm getting extraordinarily unlucky.

carlini commented 3 years ago

@googlebot I consent

carlini commented 3 years ago

(sorry for the spam everyone, trying to fix some thing)