google / objax

Apache License 2.0
769 stars 77 forks source link

Raised WARNINGS if input arguments dont have same shape #223

Closed iamharsha1999 closed 3 years ago

iamharsha1999 commented 3 years ago

Related to Issue #190. I have included warning checkpoints only to those functions that doesn't raise error by default in order to avoid unnecessary warnings.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

iamharsha1999 commented 3 years ago

@googlebot I signed it!

iamharsha1999 commented 3 years ago

I have rectified the errors from linting and unit tests. Kindly verify and the merge. Issue #190

iamharsha1999 commented 3 years ago

Can I know why its taking so long for workflow approval ?

iamharsha1999 commented 3 years ago

@david-berthelot @AlexeyKurakin Can you please approve the workflow and run the tests ?