search

google / objax

Apache License 2.0
769 stars 77 forks source link

Move RNN to layers.py and make it stateless. #97

Open aterzis-google opened 4 years ago

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

ebrevdo commented 3 years ago

I am ooo and will return next week.

On Wed, Oct 28, 2020, 5:44 PM Andreas Terzis (Google) < notifications@github.com> wrote:

@aterzis-google https://github.com/aterzis-google requested your review on: #97 https://github.com/google/objax/pull/97 Move RNN to layers.py and make it stateless..

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/google/objax/pull/97#event-3933950523, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANWFG4JVHW6MNO2S5U5WFTSNC3FJANCNFSM4SNTPVWA .