search

google / open-location-code

Open Location Code is a library to generate short codes, called "plus codes", that can be used as digital addresses where street addresses don't exist.
https://plus.codes
Apache License 2.0
4.09k stars 472 forks source link

Update JSON file access by karma/jasmine tests #324

Open drinckes opened 5 years ago

drinckes commented 5 years ago

Existing node JS tests (in js/test) use a combination of gulp and phantomjs to run.

phantomjs is now unsupported (and seems to be a pain to get working locally) so it would be good to refactor the tests to use karma/jasmine.

I've had a quick go at this but got stuck trying to get the test functions to access the CSV files. (If we have to we could convert them to JSON as part of the test script.)

drinckes commented 5 years ago

This is mostly done with #305. But this uses karma-jasmine-jquery which hasn't been updated for a long time, and has a lot of issues with pulling in old, obsolete dependencies.

So it would be good if someone with a bit more time and karma/jasmine experience could find a more up-to-date way to access JSON files from within tests.

fulldecent commented 3 years ago

Recommended tag: implementation