Closed benno-p closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Thanks for contributing! Would it be possible to add tests so that we can guard against future bugs/breakages? Some pointers: https://github.com/google/open-location-code/blob/master/CONTRIBUTING.md https://github.com/google/open-location-code/blob/master/TESTING.md
Thanks for the return,
I added files for testing the pluscode functions.
I'm not comfortable with bazel…
Is it okay for you ?
Benoit Perceval
De : bilst [mailto:notifications@github.com] Envoyé : mardi 24 novembre 2020 00:11 À : google/open-location-code open-location-code@noreply.github.com Cc : Benno b.perceval@superceval.fr; Author author@noreply.github.com Objet : Re: [google/open-location-code] Pluscode implementation for plpgsql (PostgreSQL) (#419)
Thanks for contributing! Would it be possible to add tests so that we can guard against future bugs/breakages? Some pointers: https://github.com/google/open-location-code/blob/master/CONTRIBUTING.md https://github.com/google/open-location-code/blob/master/TESTING.md
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/open-location-code/pull/419#issuecomment-732479284 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWIWKTQZQJO465OIZGGWYTSRLTYHANCNFSM4TWH3BSQ . https://github.com/notifications/beacon/AJWIWKRQLUWPDEFJZPQKD4DSRLTYHA5CNFSM4TWH3BS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFOUL6NA.gif
Classic functions : pluscode_isvalid() pluscode_isshort() pluscode_encode() pluscode_decode() pluscode_shorten() pluscode_codearea() pluscode_cliplatitude() pluscode_normalizelongitude()