google / open-location-code

Open Location Code is a library to generate short codes, called "plus codes", that can be used as digital addresses where street addresses don't exist.
https://plus.codes
Apache License 2.0
4.06k stars 472 forks source link

Noop: Omit type annotations for local variables. #421

Closed YuzuruT closed 3 years ago

YuzuruT commented 3 years ago

Following the style suggestion in effective dart

omit_local_variable_types

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

YuzuruT commented 3 years ago

@googlebot I signed it!

sugoi-yuzuru commented 3 years ago

The style fixes now include

  1. omit_local_variable_types
  2. prefer_adjacent_string_concatenation
  3. always_declare_return_types
  4. prefer_single_quotes
  5. prefer_is_not_empty
  6. prefer_contains