search

google / open-location-code

Open Location Code is a library to generate short codes, called "plus codes", that can be used as digital addresses where street addresses don't exist.
https://plus.codes
Apache License 2.0
4.07k stars 473 forks source link

null safety added #552

Closed fasil2401 closed 1 year ago

fasil2401 commented 1 year ago

I just added null safety in dart section now its ready to use in flutter apps

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

bocops commented 1 year ago

@fasil2401 I haven't seen anyone around who could merge your PR in months. That said, this PR would probably not be merged in its current form, anyway. Most of the existing tests have been commented out, also some imports and individual lines of documentation/licensing.

Most of that should probably not have been removed in the first place - and if removal is the correct thing to do, it should have been removed completely and not kept in the files as commented out code.

fasil2401 commented 1 year ago

It was a mistake. And i didn't notice that test is commented

fasil2401 commented 1 year ago

Closed pull request.i haven't noticed that test section commented Sorry about that. I will rework and submit the same. Thank you all for your help

On Sun, 5 Mar, 2023, 7:29 pm Andreas, @.***> wrote:

@fasil2401 https://github.com/fasil2401 I haven't seen anyone around who could merge your PR in months. That said, this PR would probably not be merged in its current form, anyway. Most of the existing tests have been commented out, also some imports and individual lines of documentation/licensing.

Most of that should probably not have been removed in the first place - and if removal is the correct thing to do, it should have been removed completely and not kept in the files as commented out code.

— Reply to this email directly, view it on GitHub https://github.com/google/open-location-code/pull/552#issuecomment-1455099946, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVVE75ESZDIBN6RWY4CPUULW2SL4LANCNFSM6AAAAAAVONHEHM . You are receiving this because you were mentioned.Message ID: @.***>