search

google / open-location-code

Open Location Code is a library to generate short codes, called "plus codes", that can be used as digital addresses where street addresses don't exist.
https://plus.codes
Apache License 2.0
4.07k stars 473 forks source link

Fix missing cstdint on GCC 13 #574

Closed Ferenc- closed 5 months ago

Ferenc- commented 5 months ago

Without this change the code can not be compiled with the latest GCC 13 because an error reported on openlocationcode.cc:139:3.

error: 'int64_t' was not declared in this scope
note: 'int64_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?

The porting guide of GCC 13 explains, that cstdint might need to be explicitly included: https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes

Ferenc- commented 5 months ago

@drinckes @bocops For your kind review.

bocops commented 5 months ago

@Ferenc- Thanks for the mention, I reviewed the change which looks OK to me.

However, I'm just a contributor to this repository, and haven't seen any Googler around for quite a while. Pinging some of the Googlers that have worked on this in the past: @zongweil @bilst

Ferenc- commented 5 months ago

@grah76 Thank you so much for merging! May I ask whether there is a plan to release a new version in the near future?

grah76 commented 5 months ago

@Ferenc- Thanks for the contribution!!. We don't have any plans as of now. But we will keep you posted whenever we release a new version.