search

google / open-vcdiff

An encoder/decoder for the VCDIFF (RFC3284) format
Apache License 2.0
186 stars 52 forks source link

vcdiff_test.sh specifies potentially incorrect shell location, test fails #26

Closed Steelskin closed 8 years ago

Steelskin commented 10 years ago

Original issue 26 created by greenreaper on 2010-03-18T14:54:43.000Z:

What steps will reproduce the problem?

  1. Download source package and extract with tar xvf
  2. Run ./configure && make && make check

What is the expected output? What do you see instead?

I expect all the tests to pass. Instead, the last test involving src/vcdiff_test.sh did not pass.

The error code given was: ./src/vcdiff_test.sh: not found FAIL: src/vcdiff_test.sh

What version of the product are you using? On what operating system?

Version 0.7 on FreeBSD 7.1-RELEASE-p8 in an OS-based jail.

Please provide any additional information below.

On this system, bash is located in /usr/local/bin/bash. The first line of the .sh file src/vcdiff_test.sh specifies /bin/bash

When unpacked, the source file was not writable. If set writable, and the shebang line line was removed, or changed to specify /usr/local/bin/bash, the test worked.

Steelskin commented 9 years ago

We should probably change that file to use sh instead of bash. Will take a look after #48 is fixed.