google / open-vcdiff

An encoder/decoder for the VCDIFF (RFC3284) format
Apache License 2.0
187 stars 52 forks source link

EncodeToInterface and DecodeToInterface methods should be public #70

Open DominikDeak opened 8 years ago

DominikDeak commented 8 years ago

The VCDiffEncoder::EncodeToInterface method and the corresponding VCDiffDecoder::DecodeToInterface are currently private in their respective classes.

I don't see the rationale behind this, because the streaming versions of the encoder/decoder classes publicly expose methods that work with OutputStringInterface derived objects.

The aforementioned methods should be made public, because working with OutputStringInterface offers more flexibility.