google / openhtf

The open-source hardware testing framework.
Apache License 2.0
537 stars 215 forks source link

Continuous Integration: python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] #1185

Closed cclauss closed 3 weeks ago

cclauss commented 1 month ago

Test on current versions of Python.


This change is Reviewable

glados-verma commented 4 weeks ago

A little bit of work is need to support 3.12 and newer - I made partial progress. I think the only thing still needing work is making the built-in test profiling work correctly - for some reason the generated profile files seem to be empty.

glados-verma commented 4 weeks ago
      profile_tempfile = tempfile.NamedTemporaryFile(delete=False)

The new optional parameter in Python 3.12 is called delete_on_close which is different than delete.

Yes, but: If delete is false, the value of delete_on_close is ignored from NamedTemporaryFile

glados-verma commented 3 weeks ago

I'm looking into the profiling breakage under Python3.12+. The error message might be misleading.

cclauss commented 3 weeks ago

https://docs.python.org/3/whatsnew/3.12.html#distutils

glados-verma commented 3 weeks ago

The distutils related issue is already fixed in #1183 . The problem right now is that the profiling unit test fails. I have found the cause for the breakage. It looks like the profiling implementation in OpenHTF isn't quite right, so I'm looking into that now.

glados-verma commented 3 weeks ago

1194 fixes the profiling issue

glados-verma commented 3 weeks ago

Thanks for the PR!