openintent-wifi-access_points.schema.json formatting review

[benea11]

Hi Jake,

I've spent some time reading through the access_point schema, without paying too much attention to anything other than the formatting of the file. Here are some notes to consider

• [x] Line 5: Title should be with a lowercase T
• [x] Line 71: coorindate_xyz has a typo, = coordinate
• [x] Line 74: I think coordinate_latlong technically should be coordinate_lat_long in snake_case. (Also line 207)
• [ ] Line 10: consider versioning within the properties of each schema. It can help with the different products integrating the schema, allowing them to verify the schema version in code

  "properties": {
   "version": {
     "type": "string",
     "description": "version of the OpenIntent schema",
     "enum": [
       "1.0.0"    
     ]
   }
  }

• [ ] Line 134: Should this and Line 138 have a (or multiple) unit(s) specified (eg. dBm, mW)
• [ ] Line 229: Should there be a consideration for imperial measurements too? Like what has been done on line 200

[jsnyder81]

minItems, oneOf are part of the jsonschema keywords, and cannot be changed. Which they likely came from JS notation which prefers this style

I'm interested in why you would want to version each property, instead of the schema as a whole. This gets really messy when it comes to which things you support from which version. I think our current plan is to implement versioning per schema, and then bundle the schemas into a release so you can say "i support bundle 1.0" and you know what all the schema files look like. This will get more critical as we break some of the schemas apart so they can be versioned.

[benea11]

Thx for correcting me on the JSON keywords, completely missed that, have removed those 2 points.

regarding the versioning, I don't mean to version each individual property, but rather add the version as a property. I think this is a personal preference thing. In the past, I have added the version as a property to make it a little easier to query later in code (arguably negligible). In reality, I think there is little difference to have it at the top level or as a property - other than having at the top level is going to be more prominent.