search

google / openrtb

OpenRTB model for Java and other languages via protobuf; Helper OpenRTB libraries for Java including JSON serialization
Apache License 2.0
397 stars 190 forks source link

protoc warnings #157

Open jamescooper-blis opened 3 years ago

jamescooper-blis commented 3 years ago

Generating the code on Ubuntu 20.04 generates warnings. A small amount is here:

openrtb.proto:2166:3: warning: When enum name is stripped and label is PascalCased (Iab11), this value label conflicts with IAB1_1. This will make the proto fail to compile for some languages, such as C#.
openrtb.proto:2172:3: warning: When enum name is stripped and label is PascalCased (Iab12), this value label conflicts with IAB1_2. This will make the proto fail to compile for some languages, such as C#.
openrtb.proto:2176:3: warning: When enum name is stripped and label is PascalCased (Iab13), this value label conflicts with IAB1_3. This will make the proto fail to compile for some languages, such as C#.
openrtb.proto:2189:3: warning: When enum name is stripped and label is PascalCased (Iab14), this value label conflicts with IAB1_4. This will make the proto fail to compile for some languages, such as C#.

protoc version:

$ protoc --version
libprotoc 3.6.1

FWIW, we're generating C++ code, not C#. Google's comments: https://github.com/protocolbuffers/protobuf/issues/2179

ranjithv commented 2 years ago

Any plans of fixing these warnings? It shows up every time I compile my maven project